Wallet policy registration should fail if a pubkey has the wrong version

LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors

Apache License 2.0

93 stars 69 forks source link

Wallet policy registration should fail if a pubkey has the wrong version #240

Closed bigspider closed 6 months ago

bigspider commented 6 months ago

Currently, the app ignores the BIP32 version for an external pubkey during wallet policy registration, for example if a tpub is provided instead of an xpub, or vice versa.

It would be better to fail in that case, as a sanity check.

(thanks to @Rob1Ham for reporting the issue)