codecov-commenter
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.85%. Comparing base (
031719b) to head (3f3e349). Report is 3 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #250 +/- ## ======================================== Coverage 84.85% 84.85% ======================================== Files 17 17 Lines 2192 2192 ======================================== Hits 1860 1860 Misses 332 332 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.85% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
sonarcloud[bot]
During wallet policy registration, this allows the device to recognize, and explicitly mark as 'dummy', any xpub that has the public key equal to
0250929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0, which is a standard provably unusable (NUMS) public key defined in BIP-341.This is important because it allows to use unspendable pubkeys in the taproot keypath (for example if all spending conditions require scripts), without the user having to verify by themselves that suck pubkeys are indeed unspendable.
Closes: #232