LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors
Apache License 2.0
93 stars 69 forks source link

Allow up to 5 data pushes in OP_RETURN outputs #259

Closed bigspider closed 4 months ago

bigspider commented 4 months ago

Closes: #245

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (e6b45ad) to head (5fe7f05).

Files Patch % Lines
src/common/script.c 93.75% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #259 +/- ## =========================================== + Coverage 84.85% 84.89% +0.04% =========================================== Files 17 17 Lines 2192 2205 +13 =========================================== + Hits 1860 1872 +12 - Misses 332 333 +1 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/259/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/259/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.89% <93.75%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud