LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors
Apache License 2.0
93 stars 69 forks source link

Remove Nano S target #262

Closed bigspider closed 2 months ago

bigspider commented 2 months ago

Removes the Nano S compilation target. Also removes some RAM and code size optimizations that are not longer worth the added code complexity.

The latest Nano S version is kept in the nanos branch.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (develop@4bc144a). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #262 +/- ## ========================================== Coverage ? 84.77% ========================================== Files ? 17 Lines ? 2187 Branches ? 0 ========================================== Hits ? 1854 Misses ? 333 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/262/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.77% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
44.4% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint