codecov-commenter
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.73%. Comparing base (
1a5b170) to head (40c3623).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #270 +/- ## =========================================== - Coverage 84.77% 84.73% -0.05% =========================================== Files 17 17 Lines 2187 2181 -6 =========================================== - Hits 1854 1848 -6 Misses 333 333 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.73% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
sonarcloud[bot]
Implements a substantial refactoring of the signing flow, allowing to simplify the UX code and implement the new design guidelines for Stax/Flex, using the new standard NBGL use cases.
Incidentally, it also improves the signing performance by 1-2s on typical transactions (on Stax/Flex only).
The UX for the wallet policy registration is also reimplemented using NBGL, reducing the number of taps/swipes required. Simplified the language, switching from "wallet policy" to the more simple "account".
Unrelated to the other changes, also includes a fix for the formatting of certain OP_RETURN outputs (4b1f0e0895ba30bad455f386a2b01f1568fdb6f6).
Prepares the next release 2.2.4.
Closes: #265.