search

LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors
Apache License 2.0
93 stars 69 forks source link

Fix `signMessage` failing for messages of certain lengths #273

Closed bigspider closed 1 month ago

bigspider commented 1 month ago

A bug present since version 2.2.2 makes signMessage fail for certain message lengths, due to an overflow in the requests to the client in the new UX for arbitrary message lengths.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.73%. Comparing base (6367fb2) to head (23d0ddf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #273 +/- ## ======================================== Coverage 84.73% 84.73% ======================================== Files 17 17 Lines 2181 2181 ======================================== Hits 1848 1848 Misses 333 333 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/273/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/273/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.