search

LedgerHQ / app-monero

Monero wallet application for Ledger Nano S & X
Apache License 2.0
273 stars 101 forks source link

Churning results to weird destination address #15

Closed dzonatan closed 5 years ago

dzonatan commented 6 years ago

When churning (sweep_all) from main address to main address the destination address shown in Ledger is not the real one you're churning from/to. Also the amount is "0". I had no balls to proceed and see where it goes.

Churning to different address/subaddress works ok - the destination and amount is legit.

johnalanwoods commented 6 years ago

Interesting I will test this tomorrow. Any issue with normal transfer? What OS? What Beta version?

dzonatan commented 6 years ago

macOS beta 5 main net

With normal transfer from main address to main address only fee confirmation is shown on Ledger. After that destination/amount confirmation does not appear and cli asks again if you really want to proceed this transaction. Is this intentional to skip second confirmation when sending to the same address?

cslashm commented 6 years ago

Hi. The fact is that I don't display (by choice) amount when it is the main address. Maybe this will be changed. But it means "change" will be always display for normal transaction.

When amount is zero, I think I will skip the validation, to avoid confusion.

So, what you describe is only "non-friendly" GUI side effects in some special case. So, depending on users claim I will fix them or not ;)

Le ven. 1 juin 2018 à 09:22, Rokas Brazdžionis notifications@github.com a écrit :

macOS beta 5

With normal transfer from main address to main address only fee confirmation is shown on Ledger. After that destination/amount confirmation does not appear and cli asks again if you really want to proceed this transaction. Is this intentional to skip second confirmation when sending to the same address?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/blue-app-monero/issues/15#issuecomment-393789212, or mute the thread https://github.com/notifications/unsubscribe-auth/AFOX8_ehd3xEsQw6e3ykfddhGpiXyOT3ks5t4OvDgaJpZM4UVcNv .

dzonatan commented 6 years ago

@cslashm what about address confirmation when using sweep_all to the same main address? The destination confirmation is shown on Ledger. But with completely different address. Don't even know where it comes from. This looks misleading... as it seems like you're sweeping all your XMR to that random address.

dzonatan commented 6 years ago

@cslashm ping.

cslashm commented 6 years ago

See it. Will check.

Le mer. 6 juin 2018 à 22:34, Rokas Brazdžionis notifications@github.com a écrit :

@cslashm https://github.com/cslashm ping.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/blue-app-monero/issues/15#issuecomment-395204552, or mute the thread https://github.com/notifications/unsubscribe-auth/AFOX8xIq0a4-zCKl3Abz_6zlSATo88W9ks5t6Dy8gaJpZM4UVcNv .

cslashm commented 6 years ago

So

If you sweep all to main address you have fee confirmation, then a zero amount to random address.

If you sweep all to other address you have the same thing plus amount sweeped and destination.

I just tried and it is what I get. Please tell me more on your pb.

Le ven. 1 juin 2018 à 13:06, Rokas Brazdžionis notifications@github.com a écrit :

@cslashm https://github.com/cslashm what about address confirmation when using sweep_all to the same main address? The destination confirmation is shown on Ledger. But with completely different address. Don't even know where it comes from. This looks misleading... as it seems like you're sweeping all your XMR to that random address.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/blue-app-monero/issues/15#issuecomment-393848511, or mute the thread https://github.com/notifications/unsubscribe-auth/AFOX822C01ATN_dUhnkFI9uo9tHh5gs7ks5t4SBFgaJpZM4UVcNv .

dzonatan commented 6 years ago

Correct. There is no problem for the outcome.

I'm just saying that this looks a bit misleading... Especially when you're a new user and don't know this whole workflow you mentioned. At first glance it feels like you're sweeping all your XMR to that, and only one, destination address you have to confirm on your ledger.

But maybe it's just me. Feel free to close this issue or keep it if you think that too. ☮️

johnalanwoods commented 6 years ago

Yes, for users a random XMR addy seems weird no?