search

LedgerHQ / app-monero

Monero wallet application for Ledger Nano S & X
Apache License 2.0
273 stars 101 forks source link

Suggestion: XMR private viewkey export by default #27

Open dnaleor opened 5 years ago

dnaleor commented 5 years ago

To enhance the UX , I propose the following:

When the first time the Ledger asks to export the viewkey, the ledger could instead ask:

"Export viewkey by default?"

YES => The viewkey will always be exported, no need to push the button each time. There should be a flag in the Monero app to turn the default exporting off. NO => the ledger won't ask this question again, but it'll ask the following:

"Export viewkey during this session?"

YES => The viewkey will be exported by default until the ledger is disconnected. NO => the ledger could ask the following:

"One time viewkey export?"

YES => normal behavior, like it's functioning now. NO => The ledger will ask this (one time) question:

"Never export viewkey?"

YES => the ledger won't ask to export the viewkey, unless this flag is reversed in a new setting. NO => nothing changes

During normal usage of the ledger:

if default_export is on => export private viewkey by default if default_export is off & never_export is off => always ask for session exporting. If answered by no, ask for one time export. if deault_export is off & never_export is on => never ask for exporting the viewkey

cslashm commented 5 years ago

I understand the need. I suggest a new entry in setting to set the behavior.

mmbyday commented 5 years ago

+1 This is extra friction and often confusing for the beginner/average monero user, especially the double press required. If possible, should be single press to export view key.

cslashm commented 5 years ago

The double press is a sideeffect of client code at creation. I will try to fix it for 0.14 if not too buzy on other stuff

snaggen commented 5 years ago

Having a setting would improve usability a lot... I tend to forget that I need to export the viewkey, so I just plugin my ledger and open the wallet and then it looks like nothing works.... until I 30 seconds later looks around trying to figure out what is wrong and sees the text on the Ledger. This happens to me more often than it should... so having a default behaviour in a setting would be nice.

cslashm commented 5 years ago

planned in 1.4.0

Mansarde commented 4 years ago

@dnaleor What is the difference between session and one-time export?

I understand the session export like this:

Would the one-time export work like this?

dnaleor commented 4 years ago

@Mansarde yeah something like that. Although you may simplify and just only use "session export" or only the "one time export". The most important change would be a flag to export by default

skorokithakis commented 3 years ago

Agreed about the necessity of this feature. I'd go one further and have wallets optionally store the view key on the device, and thus not require the Ledger to be connected unless it's needed for sending or (more rarely) for getting more subaddresses.