search

LedgerHQ / app-near

Ledger repo for Near app
MIT License
11 stars 9 forks source link

Increase memory size for Nano X and Nano S+ #18

Closed volovyks closed 1 year ago

volovyks commented 1 year ago

Any feedback on this? How should we proceed?

kaifeur commented 1 year ago

@volovyks have you checked this? https://developers.ledger.com/docs/embedded-app/maintenance/

volovyks commented 1 year ago

@kaifeur filled the form

kaifeur commented 1 year ago

I opened the original PR on Aug 21 2022 and the feature is still not on my Ledger yet :) @jibeee, @sgliner-ledger or @xchapron-ledger could you help with this one?

xchapron-ledger commented 1 year ago

I opened the original PR on Aug 21 2022 and the feature is still not on my Ledger yet :) @jibeee, @sgliner-ledger or @xchapron-ledger could you help with this one?

Sorry for the late reply. We will have a look into this soon will working on some adaptation for Stax device.

PierreLeGuen commented 1 year ago

@xchapron-ledger, do you have any updates on this? It's a highly anticipated change within the NEAR ecosystem.

tdejoigny-ledger commented 1 year ago

@volovyks @PierreLeGuen, did you test this code ? it seems that it's not working... It seems that the issue is here :

  static int check_overflow(unsigned int processed, unsigned int size) {
      PRINTF("check_overflow %d %d %d\n", processed, size, tmp_ctx.signing_context.buffer_used);
      if (size > tmp_ctx.signing_context.buffer_used || processed + size > tmp_ctx.signing_context.buffer_used) {
          return SIGN_PARSING_ERROR;
      }
      return 0;
  }

Always return SIGN_PARSING_ERROR