search

LedgerHQ / app-ont

MIT License
2 stars 3 forks source link

Firmware updated, but version number still v1.0.0 #4

Closed nickfujita closed 5 years ago

nickfujita commented 6 years ago

I just reinstalled the ledger firmware for the ONT app today from the Ledger Live app, and it seems like fix for issue https://github.com/LedgerHQ/ledger-app-ont/issues/1 from commit 76356de89f4f10106a8c11727e4200b7bb9551b8 is not included. However, there is no indication to users that this update has been made. The version number of the application is still v1.0.0, so users who downloaded the app firmware before the updated will not know that the update has happened.

This is important because existing users will have to be told via support to manually uninstall and reinstall the app, even though the version number has not changed. This seems to be a poor user experience, as they have no way to know if they have the fixed version or not, without going and testing the ledger with an app that supports NEO based addresses on their ledger.

Could the version number please be incremented to v1.0.1?

xizho10 commented 5 years ago

i am sure if is just to change APPVERSION in Makefile , or change release version in Ledger Live.

nickfujita commented 5 years ago

I am referring to the version in Ledger Live.

image

xizho10 commented 5 years ago

yes, the version 1.0.0 , i don't know is write in firmware or Ledger official set the version.

nickfujita commented 5 years ago

Then I guess the correct person to answer this question is someone from the Ledger team. Are you affiliated with the Ledger team, or know someone that is?

xizho10 commented 5 years ago

i am from ontology.

nickfujita commented 5 years ago

If there is someone on the Ledger team that is watching this repo, could you please respond. We are already fielding many support questions related to the update mentioned in this issue, but since the version number of this ledger app was never updated, users think they are on the latest version of the app, but are actually not. A uninstall and reinstall on their end will solve the issue, but it's causing a lot of unnecessary confusion for users and time wasted for all.

xizho10 commented 5 years ago

I saw the Ontology version has change to 1.2.0 in Ledger Live.

nickfujita commented 5 years ago

Confirmed update to v1.2.0. Closing.