LedgerHQ / app-openpgp

OpenPGP Card Application
Apache License 2.0
123 stars 21 forks source link

App improvements after 1st refactoring #96

Closed cedelavergne-ledger closed 8 months ago

cedelavergne-ledger commented 9 months ago

The proposed improvements are:

Checklist

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.27%. Comparing base (91cdd1f) to head (db6242b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #96 +/- ## ======================================== Coverage 27.27% 27.27% ======================================== Files 1 1 Lines 209 209 ======================================== Hits 57 57 Misses 152 152 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-openpgp/pull/96/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-openpgp/pull/96/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `27.27% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.