Prevent null dereference

LedgerHQ / app-ssh-agent

Simple SSH and GPG agent for Ledger Blue and Nano S

Apache License 2.0

81 stars 27 forks source link

Prevent null dereference #40

Closed yhql closed 10 months ago

yhql commented 10 months ago

Prevent using an uninitialized state in business.c that would trigger passing a null pointer during hashing
add some standard ci files for ledger apps

github-advanced-security[bot] commented 10 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

yhql commented 10 months ago

@xchapron-ledger do you think we could merge this (security fix) despite the guidelines failures (API deprecation, missing Stax flags) ?

xchapron-ledger commented 10 months ago

@yhql I think you could use https://github.com/LedgerHQ/ledger-app-workflows/blob/master/.github/workflows/reusable_guidelines_enforcer.yml#L6C15-L6C15 to disable Stax CI and therefore please the CI.

xchapron-ledger commented 10 months ago

@yhql Also bump the version so that we can deploy it?

yhql commented 10 months ago

@xchapron-ledger should be (more) ok now, thanks for the help