LedgerHQ / app-starknet

Official Ledger Starknet application (Rust implementation)
Apache License 2.0
15 stars 4 forks source link

Clear-sign ETH/STRK transfer #26

Open yogh333 opened 2 months ago

yogh333 commented 2 months ago

Scope:

yogh333 commented 2 months ago

Specifications update:

yogh333 commented 1 month ago

see #28

yogh333 commented 1 week ago

Following some internal discussions and after feedbacks from Starknet wallet developers (Argent-X, Braavos), it has been decided to extend the first Milestone:

  1. To support Tx v1 signing as it is still used (despite being signalled as deprecated on Starknet official documentation) when end-user wants to pay fees in ETH (Tx v3 is used when fees to be paid in STRK token). Tx v1 will be clear-signed when dealing with ETH or STRK transfers, displaying same info as for Tx v3 (From, Amount, Ticker, To, Max Fees) or blind signed for every other types of operations (Pedersen hash of the Tx will be displayed in that case).
  2. To support blind-signing of off-chain message (see SNIP-12) through a new signMessage() function: message hash will be computed by the client (using starknet.js) and the hash will be sent to the device to be displayed and signed if end-user confirms.
  3. Both 1. and 2. items require to update the starknet-js client, and thus a new release of this client will be also performed and integrated by Starknet wallets in order to support the next app version.
dhruvkelawala commented 1 week ago

Lgtm!