search

LedgerHQ / app-stellar

Stellar app for Ledger Nano S
Apache License 2.0
15 stars 23 forks source link

Add manageBuyOffer support (help needed) #6

Closed MisterTicot closed 3 years ago

MisterTicot commented 5 years ago

This is an attempt to add support for manageBuyOffer.

However, it stalls on "Confirm Transaction".

I've tested the new display logic for manageSellOffer. I've also tested the display logic for manageBuyOffer by setting manageOffer.buy to true in manageSellOffer parser. Both works.

I've read the changes for stellar_parser.c & stellar_types.h several time but all seems right.

My conclusion is that something else have to be changed in order to add a new operation, but I don't find it. At that point I think I need help.

My conclusion is that I forgot something

MisterTicot commented 5 years ago

It's now working fine thanks to @lenondupe.

It's still missing a test though. Is the test format the tx XDR converted to hex?

MisterTicot commented 5 years ago

Anybody here???

MisterTicot commented 4 years ago

@btchip @TamtamHero I'm waiting for you to react.