LedgerHQ / app-stellar

Stellar app for Ledger Nano S
Apache License 2.0
15 stars 23 forks source link

Stellar now returns to Exchange after a successful sign #62

Closed fbeutin-ledger closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (83f1e8e) 77.72% compared to head (44aa5cf) 77.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fbe/stellar_donjon_review #62 +/- ## ========================================================== Coverage 77.72% 77.72% ========================================================== Files 12 12 Lines 2352 2352 ========================================================== Hits 1828 1828 Misses 524 524 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `77.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fbeutin-ledger commented 1 year ago

https://github.com/LedgerHQ/app-exchange/pull/115

fbeutin-ledger commented 1 year ago

The warning

src/swap/handle_swap_sign_transaction.c:53:1: error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn]
}
^
1 error generated.

Is a false positive caused by a missing flag in the SDK API, fix in progress

fbeutin-ledger commented 1 year ago

The issue

FAILED test/python/test_stellar.py::test_stellar_swap_refuse_double_sign[nanosp 1.0.4] - ragger.error.ExceptionRAPDU: Error [0x6d00] b''

Is because the CI for Exchange tests in Stellar is using the develop branch of the exchange app

fbeutin-ledger commented 1 year ago

The issue in test_stellar_swap_refuse_double_sign is expected as the test will need an update

fbeutin-ledger commented 1 year ago

Zemu tests for Stax are broken because the Speculos version in Zemu is out of date and doest not contain the API_LEVEL_10