search

LedgerHQ / app-stellar

Stellar app for Ledger Nano S
Apache License 2.0
15 stars 23 forks source link

New Release #85

Closed overcat closed 4 months ago

overcat commented 4 months ago

Checklist

overcat commented 4 months ago

Hi @tdejoigny-ledger, If you have not yet moved on to the next step, could you also merge this PR? If you have already moved on to the next process, then let's merge it next time.

tdejoigny-ledger commented 4 months ago

Hi @tdejoigny-ledger, If you have not yet moved on to the next step, could you also merge this PR? If you have already moved on to the next process, then let's merge it next time.

sorry @overcat too late 😅

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (3d5896b) to head (88e0122). Report is 41 commits behind head on develop.

Files Patch % Lines
libstellar/parser.c 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #85 +/- ## ============================================ + Coverage 76.87% 89.36% +12.48% ============================================ Files 14 5 -9 Lines 2378 2688 +310 ============================================ + Hits 1828 2402 +574 + Misses 550 286 -264 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-stellar/pull/85/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-stellar/pull/85/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `89.36% <95.45%> (+12.48%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.