Tj/add tests - Githubissues

LedgerHQ / app-vechain

Apache License 2.0

6 stars 11 forks source link

Closed tdejoigny-ledger closed 1 year ago

tdejoigny-ledger commented 1 year ago

Add ragger tests for Nano devices before initiating the Stax porting (please note that tests for Nano S are not executed in this PR because there are based on new UX).
Add ragger tests for Stax device.
Include the small PR about the base Gas price change (to avoid to udpate the tests after)

libotony commented 1 year ago

I have another off-topic question, as a Python noob, is it possible to run ragger tests locally in a docker container?

tdejoigny-ledger commented 1 year ago

We just release a new docker (ledger-app-dev-tools) which includes ragger and Speculos 😉 You can take a look here : https://github.com/LedgerHQ/app-boilerplate

tdejoigny-ledger commented 1 year ago

@libotony sorry to push but do you know when you will have finish to review the PRs #13 and #14 ?

libotony commented 1 year ago

My plan is to finish my first view early next week, but I can not ensure it.

tdejoigny-ledger commented 1 year ago

@libotony If you don't have any extra comments I will merge today.

libotony commented 1 year ago

@libotony If you don't have any extra comments I will merge today.

Sure, I am working on #14