Closed xchapron-ledger closed 1 month ago
In https://github.com/LedgerHQ/app-vechain/blob/develop/src/main.c#L647-L652 if rLength == 31, which can happen, then the signature will be invalid and transaction will be rejected by the blockchain. A simpler implementation would be using cx_ecdsa_sign_rs_no_throw,a nd best would be changing all the crypto call to use directly helpers from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h
In https://github.com/LedgerHQ/app-vechain/blob/develop/src/main.c#L647-L652 if rLength == 31, which can happen, then the signature will be invalid and transaction will be rejected by the blockchain. A simpler implementation would be using cx_ecdsa_sign_rs_no_throw,a nd best would be changing all the crypto call to use directly helpers from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h