search

LedgerHQ / btchip-python

Ledger HW.1 Python API
http://www.ledger.co
Apache License 2.0
65 stars 51 forks source link

getTrustedInput crashes with funds sent from segwit addresses #30

Closed ecdsa closed 7 years ago

ecdsa commented 7 years ago

see https://github.com/spesmilo/electrum/commit/1ecfcea8dcfe37df4c6dceeaf071f19c7660c44b

btchip commented 7 years ago

Mmh, this code is not supposed to be called from a Segwit UTXO - also disabling it would break all non Segwit transactions

ecdsa commented 7 years ago

@btchip this code breaks when the funding transaction of a non-segwit utxo is a segwit transaction.

well, it is not the code that breaks, it is the ledger firmware

ecdsa commented 7 years ago

fixed in 7ea64d0330b0c2bbda5d60cfb91f13b5b3e7b7b6