Allow specifying "icon" for Nano S+/X

LedgerHQ / cargo-ledger

(Moved in the ledger device rust SDK --> https://github.com/LedgerHQ/ledger-device-rust-sdk). Load code on a Ledger device with a `cargo` subcommand

Apache License 2.0

15 stars 12 forks source link

Allow specifying "icon" for Nano S+/X #11

Closed dfordivam closed 2 years ago

dfordivam commented 2 years ago

The S+/X devices have a different icon than S, so it would be nice to somehow specify it in the Cargo.toml. Perhaps optional fields like "icon-nanos", "icon-nanosplus", "icon-nanox", could be supported which will override the default "icon" and still maintain backward compatibility

yhql commented 2 years ago

Ah thanks for this issue, had it in the back of my mind! Is the provided PR OK for you?

dfordivam commented 2 years ago

Hi @yhql , Confirmed that it works