search

LedgerHQ / eth-dapp-browser

https://dapp-browser.apps.ledger.com/
5 stars 9 forks source link

Update select account #20

Closed chabroA closed 1 year ago

chabroA commented 1 year ago

Update request account flow to use the AccountRequest component for desktop as well (it is already used on mobile), to allow user to add an account and to make the flow consistent with the one present on platform-app-web-browser

Loading screen

Before ![dapp-before](https://user-images.githubusercontent.com/9203826/198645844-d4c2df8b-82f6-4891-92b5-4c3a57c195df.png)
After ![dapp-after](https://user-images.githubusercontent.com/9203826/198646028-09d9f7b4-0629-41d8-b586-da128db691e4.png)

Select account

Before ![dapp-before-2](https://user-images.githubusercontent.com/9203826/198645955-11a39e82-e7f4-4003-9ab7-9f5f9284aa0b.png)
After ![dabb-after-2](https://user-images.githubusercontent.com/9203826/198646069-d5303743-bae5-4ad2-b208-859007ba04a1.png)
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
eth-dapp-browser ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 11:33AM (UTC)
chabroA commented 1 year ago

⚠️ We need to wait for Vault next release that will include requestAccount handling before merging this PR ⚠️