search

LedgerHQ / ledger-asset-dapps

12 stars 58 forks source link

Need to whitelist a Factory created contract #215

Open georgeciubotaru opened 3 months ago

georgeciubotaru commented 3 months ago

Planning to integrate the Clearpool Finance protocol apps into the Ledger, but having some issues.

Scope: Implement Clear Signing for whitelisting Clearpool contracts interactions with Ledger.

  1. We have Factory and dynamically created contract Pools, what is the flow to add them? Should we add manually one by one and repeat for each of them the abi file?

  2. Based on the structure we should define the abis folder, b2c and eip712 files, where should we declare this structure https://github.com/LedgerHQ/clear-signing-format-spec/blob/master/spec.md ?

  3. We are supporting most of the networks from the list, is it okay to have 1 PR per network, or somehow to validate the correct structure with 1 network, before proceeding with the others?

Thank you!

zolotokrylin commented 3 days ago

hey guys, could you please help us here? Thank you in advance. @noirbizarre @jprudent @hayesgm @enriquefynn