search

LedgerHQ / ledger-dotnet-api

.NET API for Ledger
MIT License
48 stars 30 forks source link

Allow Unsafe Code #18

Open MelbourneDeveloper opened 6 years ago

MelbourneDeveloper commented 6 years ago

This library allows unsafe code:

image

This will be a problem for deploying apps to stores like the Windows Store, and Google Play store.

Unsafe code can be used to increase performance, but it allows direct access to memory, so many analyzers and so on may consider the library to be malware because it is not known what the app may be doing to memory. As a general rule unsafe code should only be used when there are performance issues with device communication, but seeing that device communication is not generally an issue because of the small amounts of transfer, I don't think there will be performance issues.

NicolasDorier commented 6 years ago

We can probably remove this. Needed only for hid.dll.

MelbourneDeveloper commented 6 years ago

The other option is to build two versions.

NicolasDorier commented 6 years ago

We don'tneed unsafe code.

MelbourneDeveloper commented 6 years ago

@NicolasDorier , just FYI, someone at Microsoft are saying that their store will allow unsafe code:

https://social.msdn.microsoft.com/Forums/windowsapps/en-US/d7775be2-82b3-4ce2-a783-4956baeebfa4/allow-unsafe-code?forum=wpsubmit

Although, I don't really trust that this person knows what they are talking about.

I can't say if Unsafe is OK for Google Play or Apple stores though.

NicolasDorier commented 6 years ago

We can remove it, it is not needed anymore.