search

LedgerHQ / ledger-dotnet-api

.NET API for Ledger
MIT License
48 stars 30 forks source link

Signing P2SH transaction #24

Open sigHash opened 5 years ago

sigHash commented 5 years ago

Hi @NicolasDorier

Should I expect SignTransactionAsync to work just fine for p2sh transactions if I pass in ScripCoin in SignatureRequest?

NicolasDorier commented 5 years ago

Yes. Though if it is not segwit, you need the input transaction as well.

sigHash commented 5 years ago

Just wondering why we call it signedCoins:

public async Task<Transaction> SignTransactionAsync(KeyPath keyPath, ICoin[] signedCoins, Transaction[] parents, Transaction transaction, KeyPath changePath = null)
NicolasDorier commented 5 years ago

Don't use this overload, use the one with SignatureRequest.