Support: fix build by adding @cosmjs/amino dependency - Githubissues

LedgerHQ / ledger-live-common

⛔️ DEPRECATED - Common ground for the Ledger Wallet apps

http://ledger-live-tools.now.sh

Apache License 2.0

136 stars 173 forks source link

Support: fix build by adding @cosmjs/amino dependency #1925

Closed ghost closed 2 years ago

ghost commented 2 years ago

Context (issues, jira)

Live Common doesn't build.

src/families/cosmos/js-synchronisation.ts:11:53 - error TS2307: Cannot find module '@cosmjs/amino' or its corresponding type declarations.

11 import { pubkeyToAddress, decodeBech32Pubkey } from "@cosmjs/amino";

Description / Usage

Issue happens since https://github.com/LedgerHQ/ledger-live-common/pull/1913 where dependency to @cosmjs/ledger-amino was removed. Unclear why CI was green on that PR :confused:

The fix consists is adding only the @cosmjs/amino dependency.

Expectations

[x] Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
[x] No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-common	❌ Failed (Inspect)		May 2, 2022 at 9:00AM (UTC)