Some changes on filecoin integration - Githubissues

LedgerHQ / ledger-live-common

⛔️ DEPRECATED - Common ground for the Ledger Wallet apps

http://ledger-live-tools.now.sh

Apache License 2.0

136 stars 171 forks source link

Some changes on filecoin integration #1934

Closed emmanuelm41 closed 2 years ago

emmanuelm41 commented 2 years ago

Context (issues, jira)

Filecoin integration

Description / Usage

Change filecoin endpoint url to production version
Support both legacy and normal gif derivation modes. This is required as ledger live uses bip44 mode as default.
- Legacy: 44'/1'/0'/0/\<account>
- Normal: 44'/461'/0'/0/\<account>

Expectations

[ ] Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
[ ] No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-common	✅ Ready (Inspect)	Visit Preview	May 4, 2022 at 6:58PM (UTC)