LedgerHQ / ledger-live-common

⛔️ DEPRECATED - Common ground for the Ledger Wallet apps
http://ledger-live-tools.now.sh
Apache License 2.0
136 stars 171 forks source link

LIVE-1560 Algorand NotEnoughBalance errors in bot #1960

Closed alexalouit closed 2 years ago

alexalouit commented 2 years ago

Context (issues, jira)

Compute fees before to max spendable estimation

https://ledgerhq.atlassian.net/browse/LIVE-1560

Description / Usage

Expectations

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 13, 2022 at 6:41AM (UTC)
codecov[bot] commented 2 years ago

Codecov Report

Merging #1960 (2efced6) into develop (6a2af82) will decrease coverage by 0.05%. The diff coverage is 76.16%.

@@             Coverage Diff             @@
##           develop    #1960      +/-   ##
===========================================
- Coverage    59.42%   59.36%   -0.06%     
===========================================
  Files          510      511       +1     
  Lines        21105    21015      -90     
  Branches      5687     5669      -18     
===========================================
- Hits         12541    12475      -66     
+ Misses        8543     8518      -25     
- Partials        21       22       +1     
Impacted Files Coverage Δ
src/env.ts 65.21% <ø> (ø)
src/exchange/swap/getProviders.ts 58.33% <0.00%> (ø)
src/families/cosmos/validators.ts 61.15% <ø> (ø)
src/families/ripple/test-dataset.ts 100.00% <ø> (ø)
src/families/cosmos/js-signOperation.ts 16.66% <14.28%> (-2.46%) :arrow_down:
src/families/algorand/js-estimateMaxSpendable.ts 28.00% <33.33%> (+3.00%) :arrow_up:
src/families/ripple/bridge/js.ts 65.06% <75.60%> (-8.14%) :arrow_down:
src/families/bitcoin/wallet-btc/wallet.ts 88.32% <77.77%> (+0.17%) :arrow_up:
src/api/Ripple.ts 85.71% <80.95%> (-2.60%) :arrow_down:
src/families/cosmos/api/Cosmos.ts 87.50% <81.81%> (+0.98%) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b012ce...2efced6. Read the comment docs.

ghost commented 2 years ago

This should've been a bugfix/ branch, sorry again @lambertkevin :pray: