LedgerHQ / ledger-live-common

⛔️ DEPRECATED - Common ground for the Ledger Wallet apps
http://ledger-live-tools.now.sh
Apache License 2.0
136 stars 171 forks source link

[LIVE-1567] Feature: Update NFT types to add multiple medias #1961

Closed lambertkevin closed 2 years ago

lambertkevin commented 2 years ago

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-1795

Description / Usage

We're changing the type of media(s) returned by the metadata service.

Expectations

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 13, 2022 at 5:27PM (UTC)
codecov[bot] commented 2 years ago

Codecov Report

Merging #1961 (eb57a20) into develop (6a2af82) will decrease coverage by 0.05%. The diff coverage is 76.77%.

@@             Coverage Diff             @@
##           develop    #1961      +/-   ##
===========================================
- Coverage    59.42%   59.36%   -0.06%     
===========================================
  Files          510      511       +1     
  Lines        21105    21015      -90     
  Branches      5687     5669      -18     
===========================================
- Hits         12541    12475      -66     
+ Misses        8543     8518      -25     
- Partials        21       22       +1     
Impacted Files Coverage Δ
src/env.ts 65.21% <ø> (ø)
src/families/cosmos/validators.ts 61.15% <ø> (ø)
src/families/ripple/test-dataset.ts 100.00% <ø> (ø)
src/families/cosmos/js-signOperation.ts 16.66% <14.28%> (-2.46%) :arrow_down:
src/families/ripple/bridge/js.ts 65.06% <75.60%> (-8.14%) :arrow_down:
src/families/bitcoin/wallet-btc/wallet.ts 88.32% <77.77%> (+0.17%) :arrow_up:
src/api/Ripple.ts 85.71% <80.95%> (-2.60%) :arrow_down:
src/families/ripple/js-synchronization.ts 96.07% <96.07%> (ø)
src/errors.ts 100.00% <100.00%> (ø)
src/families/bitcoin/getAccountNetworkInfo.ts 97.14% <100.00%> (+0.17%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9308d1f...eb57a20. Read the comment docs.

lambertkevin commented 2 years ago

Closed for the monorepo: https://github.com/LedgerHQ/ledger-live/pull/68