LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
953 stars 301 forks source link

support standard URI schemes like `bitcoin:` #1236

Open ktechmidas opened 6 years ago

ktechmidas commented 6 years ago

So I recently had to pay a company and they sent me a BitPay link, alright cool. However there is absolutely nowhere on this stupid widget to actually copy the address I should be sending to. There are two options... "Copy Payment URL" and "Open in Wallet" they both lead to a bitcoin:?r URL which is opening in my empty electrum wallet instead of Ledger Live.

I then tried to copy the address from Electrum... again same issue, there is nothing showing me the address I'm sending to as you can see here:

image

So now the only solution I have is to send from the Ledger to Electrum then request a new payment invoice,

Are there any plans to support this type of ~fuckery~ really great technology using CA's that are never compromised in the future?

gre commented 6 years ago

we could technically accept the bitcoin: scheme to open the app, it's feasible. it could open the Send flow, preselect your biggest account of the corresponding crypto, prefilling the amount, address... This is what we already do when you scan a qr code.

some things to be investigate tho are:

ktechmidas commented 6 years ago

From a very Windows&Firefox centric point of view usually the OS will catch it and let you choose which app to open with if there are multiple registered like this:

image

So at least in Windows, it would be a case of registering your app to open bitcoin: URIs (and any others like litecoin: it should be possible because IE can open many schemes) - not entirely sure how this works through Windows versions though. I know one of the first guys to use this was magnet links & torrent clients, maybe they will shed some light....

On the Linux side I think the desktop environment might handle it, not entirely certain...

gre commented 6 years ago

some tech notes:

mgarciap commented 5 years ago

Hi @gre , are you still looking for help developing this feature?

ghost commented 5 years ago

The sooner this gets implemented the better; using BitPay, for example, is a real pain without support for this.

gre commented 5 years ago

Yes I think it's a great feature to support.

Golumpa commented 4 years ago

Any advancement on this? More and more payment processors are using URIs It could be possible to just "pre-fill" the boxes that the URI has information for. such as the address and amount while still requiring the user to select which wallet to choose.

If the Bitcoin URI is used only list bitcoin wallets (if only one exists, could just continue to the next step), and so on for different currencies. Prefill the address and amount to send, however, still require the user to confirm all the information on ledger live before starting the send via the device.