Missing countervalues for XLM - Stellar Integration

LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)

https://www.ledger.com/live

MIT License

953 stars 301 forks source link

Missing countervalues for XLM - Stellar Integration #1432

Closed juan-cortes closed 6 years ago

juan-cortes commented 6 years ago

I'm currently in the process of integrating Stellar into the app and so far so good, but I've hit a wall when it comes to the counter values part since it checks against the server at LEDGER_COUNTERVALUES_API and I have no control over it. In the meantime, I will attempt to mock the API and see if I can get around it for a while.

https://countervalues.api.live.ledger.com/exchanges/XLM/EUR

If this should be elsewhere, let me know and I'll go over there

gre commented 6 years ago

@juan-cortes your short term solution is probably to ignore this for now, I think the app is still functional except the graphs and countervalues to display properly.

the proper solution would be:

to send a PR on ledger-live-common to add the coin in https://github.com/LedgerHQ/ledger-live-common/blob/master/src/data/cryptocurrencies.js because live-common is the lib getting used by our countervalues api to whitelist the coins ( https://github.com/LedgerHQ/ledger-api-countervalue )
on our side, we'll have to bump it in this library. ( but will need to get https://github.com/LedgerHQ/ledger-api-countervalue/issues/10 fixed first )

juan-cortes commented 6 years ago

@gre thanks for the quick reply, I wasn't expecting anyone to be around on a sunday. Yeah, I've got some work left to do with the js bridge for sure, but as you mention, the app works without graphs and counter values. I'll take a look at what you're saying above. I'm using a local fork for ledger-live-common to the stellar to be listed in the first place so having that repo updated is crucial to get it to work.

There are multiple UI issues that would need to be addressed such as the addresses being to long for the modals and whatnot, but that's something that can wait.

https://github.com/LedgerHQ/ledger-live-common/pull/61

juan-cortes commented 6 years ago

Managed to get a local version of https://github.com/LedgerHQ/ledger-api-countervalue running locally and synced with the cryptocompare provider to get the histodays thing on the db. Once that was done, the graphs started to work again, as well as the conversion rates, exchanges and everything, including now Stellar.

juan-cortes commented 6 years ago

Think we can close this