search

LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 299 forks source link

XRP: sending transfer with a memo #2095

Closed ihomp closed 3 years ago

ihomp commented 5 years ago

In XRP any transaction can have a set of memos attached. In xrp community it's got very popular to send memos with transactions.

specs are here: https://xrpl.org/rippleapi-reference.html#transaction-memos

Apps like xrptipbot, bithomp-tools or hardware wallet Secalot supporting sending transaction with memos.

It's just an extra parameter in transaction json. it should be easy to add. Support for only plain/text memos would be a good start.

Part of the application

Ledger Live: sending XRP. JS lib: allow to sign transactions with memos in them.

ghost commented 5 years ago

@ihomp It seems the feature is already implemented. The only problem is that the XRP Tag field doesn't show up. If you try to use the tab key to navigate between fields it's going to show up at the bottom (seems to be just a UI problem). credit: found it here

gre commented 5 years ago

no, the tag is not the same as the memo.

destination tag is used in XRP protocol as complementary to the recipient.

cthepot commented 3 years ago

https://github.com/LedgerHQ/ledger-live-desktop/pull/3170