LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 297 forks source link

Add support for ENS domains #2858

Open Zaczero opened 4 years ago

Zaczero commented 4 years ago

Currently when sending a transaction no ENS domain is being resolved. Instead I'm given the error "not a valid ... address". Would love to see this dApp being implemented into Ledger Live! :-)

200416041413_Ledger_Live_bc0c37


What is ENS?

https://ens.domains/

Why?

Compatible coins/tokens (multi-coin)

... as of 16 Apr 2020

Possible use of text records

There is this thing called text records which contains few standardized fields:

I can only imagine how cool would it be to display those details while making a transaction inside the UI. A large circled avatar preview at the top, small email address below, some links (GitHub, Twitter) and a short description (maybe?). The potential is here.

200416042804_firefox_6ee793

Zaczero commented 4 years ago

Resolving ENS docs: https://docs.ens.domains/dapp-developer-guide/resolving-names

jgaweda commented 4 years ago

This would be great! ENS is critical for mass adoption!

cyanlink commented 3 years ago

yeah, unable to send to ENS domain from ledger live is really astonishing in 2020.

gre commented 3 years ago

How would you suggest the device to securely verify the address correctly correspond to that ENS domain? It's not as trivial as it seems.

cyanlink commented 3 years ago

How would you suggest the device to securely verify the address correctly correspond to that ENS domain? It's not as trivial as it seems.

@gre

Okay first I assume you have the basic idea about ethereum and smart contracts. ENS system is a set of contracts (resolvers and registry and etc) that maintains the mapping record of (sub)domain and addresses and other info on the ethereum blockchain.

All Ledger Live Software has to do is to enable the ability to lookup ENS domains which can be backed by ledger proxy API, show the user the corresponding address on UI(the ledger client also need the ability to lookup for reverse record to display a human-readable ENS domain). The ledger nano device shows the address as usual so that user can check if there are MITM between ledger live and ledger nano.

If you need to make sure that the lookup result is genuine and authentic, users have to trust infura/any other ethereum gateway provider such as ledger proxy.

roddurd commented 3 years ago

hello! I would very much still like this feature, and I'm sad that this conversation stopped and this issue is still open :(

support for ENS will be great for adoption!!!

Reuvens commented 3 years ago

+1

drakedanner commented 3 years ago

Also interested in support for ENS.

jamescook10 commented 3 years ago

Came here to see if it was supported. +1

99Thebigdady commented 3 years ago

i absolutely want that

marcocattaneogotam commented 3 years ago

+1

max-arias commented 2 years ago

+1

Jb00gy commented 2 years ago

+1

a186r commented 2 years ago

+1

Oakoakoakoak commented 2 years ago

+1

jasonrpoteet commented 2 years ago

+1

willianpaixao commented 2 years ago

+1

Danielhighfive commented 2 years ago

ENS support in 2022 is absolutely necessary! Its critical for mass adoption.

pet125 commented 2 years ago

i really want that