LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
952 stars 301 forks source link

Add the ability to add custom Ethereum ERC-20 tokens #3276

Open MartinacPlus opened 4 years ago

MartinacPlus commented 4 years ago

Part of the application

gre commented 4 years ago

It's not that simple because you need Ledger's signature to properly display an ERC20 on the device. The feature is still considered but it would be a message to sign on the device and you would not see the token and the amount on the device. This is the main reason we don't have "all possible" tokens.

MartinacPlus commented 4 years ago

Sorry, I'm not sure I understood. Now I use the MetaMask's Firefox plugin to which I authenticate with my Ledger Nano devices. I'm able to sign transactions, see tokens and Ethereum balances. Why the same thing cannot be done on Ledger Live? Or is the way it is implemented in MetaMask unsafe?

devli13 commented 3 years ago

@MartinacPlus Agreed with this comparison brought up regarding metamask. I have been told by Ledger staff that this functionality is being worked on for the enterprise solution but would be great to have for consumers to easily add tokens by smart contract.

@gre , I think many would be okay with all the message details on the ledger device given interactions with smart contracts already offer limited transparency of the metadata on the ledger nano device.