LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 297 forks source link

fix(swap): properly sort the source account selector [LIVE-819] #4903

Closed Justkant closed 2 years ago

Justkant commented 2 years ago

πŸ¦’ Context (issues, jira)

LIVE-819

πŸ’» Description / Demo (image or video)

Fix the sort of the source selector by putting fully disabled accounts / token accounts at the bottom of the list while preserving the parent/children grouping.

Before:

image-20220228-124928

After:

Screenshot 2022-04-08 at 11 13 35

πŸ–€ Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

github-actions[bot] commented 2 years ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements
23.46% (+14.72% πŸ”Ό)
38/162
πŸ”΄ Branches
20.51% (+20.51% πŸ”Ό)
8/39
πŸ”΄ Functions 3.64% 2/55
πŸ”΄ Lines
24.16% (+15.83% πŸ”Ό)
36/149
Show new covered files 🐣 |
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :---------------------------------------------------------------------------------------------------------------------------------------: | :---------------------------------------------------------- | :--------- | :------- | :-------- | :----- | | πŸ”΄ |
`...` / swap.js
| 49.15% | 40% | 4.76% | 52.83% |

Test suite run success

2 tests passing in 2 suites.

Report generated by πŸ§ͺjest coverage report action from 888bf8458941ddeee1fa3a641a8b1e92f506ad52