alexandremgo commented 2 years ago

🦒 Context (issues, jira)

The "something else" choice redirects to the end of the usb-troubleshooting flow

Add to adapt a bit compared to the given design (from figma): the Nano S repair modal is old and has not been updated to the new troubleshooting screens.

💻 Description / Demo (image or video)

Video: new feature

https://user-images.githubusercontent.com/15096913/163337621-789599a3-3066-4cf5-ab43-f8fe0d16d1ec.mp4

Video: the other repair modal screens are not broken

https://user-images.githubusercontent.com/15096913/163339871-774ec649-5b2c-4929-b752-bc429613c3e8.mp4

🖤 Expectations to reach

on QA: at least one of these two checkboxes must be checked:
- [x] a specific test planned is defined on Jira
- [ ] this PR is covered by automatic UI test
on delivery: at least one of these two checkboxes must be checked:
- [ ] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
- [x] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

[ ] pass the CI
[ ] if needed, run /generate-screenshots
[ ] have a dev review
[ ] have a QA review
[ ] if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

github-actions[bot] commented 2 years ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	8.74%	9/103
🔴	Branches	0%	0/19
🔴	Functions	2.94%	1/34
🔴	Lines	8.33%	8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 3ed7e504846375dc82521c53bb05238f7639391e

LedgerHQ / ledger-live-desktop

[LIVE-1317] "something else" choice at repair modal for Nano S #4926