Closed ofreyssinet-ledger closed 2 years ago
Thanks for your contribution. To be able to merge in develop branch, you need to:
/generate-screenshots
[ ] if needed, /upgrade-llc
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc
to switch back to ledger-live-common@develop here before merging.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π΄ | Statements | 23.46% | 38/162 |
π΄ | Branches | 20.51% | 8/39 |
π΄ | Functions | 3.64% | 2/55 |
π΄ | Lines | 24.16% | 36/149 |
Report generated by π§ͺjest coverage report action from 3e6bb3f2000f887b83e3872de6ac732597005478
/generate-screenshots
Tested on linux + spanish: new users flow :heavy_check_mark: existing users :heavy_check_mark:
With this change, we add more languages (Chinese and Spanish) to the list that makes it easy for existing users and new users to switch to their OS language:
π¦ Context (issues, jira)
LIVE-1928
π» Description / Demo (image or video)
new users:
https://user-images.githubusercontent.com/91890529/164006563-0eef5118-83bf-470c-87e0-42aec001b951.mov
existing users (simulating "existing user" by doing a 1st start with the OS language in English and then after changing the OS language to Spanish, restarting LL):
https://user-images.githubusercontent.com/91890529/164007283-2bd6bb7e-9bfa-4392-b83a-03a0fddcd92f.mov
π€ Expectations to reach
Discoverability for new users (fully supported languages):
Discoverability for existing users
PR must pass CI, rebase develop if conflicts. Thanks!