LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 297 forks source link

LIVE-1928 LIVE-1776 - Add Spanish (ES) and Chinese (ZH) to pushed languages #4933

Closed ofreyssinet-ledger closed 2 years ago

ofreyssinet-ledger commented 2 years ago

With this change, we add more languages (Chinese and Spanish) to the list that makes it easy for existing users and new users to switch to their OS language:

πŸ¦’ Context (issues, jira)

LIVE-1928

πŸ’» Description / Demo (image or video)

new users:

https://user-images.githubusercontent.com/91890529/164006563-0eef5118-83bf-470c-87e0-42aec001b951.mov

existing users (simulating "existing user" by doing a 1st start with the OS language in English and then after changing the OS language to Spanish, restarting LL):

https://user-images.githubusercontent.com/91890529/164007283-2bd6bb7e-9bfa-4392-b83a-03a0fddcd92f.mov

πŸ–€ Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

github-actions[bot] commented 2 years ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements 23.46% 38/162
πŸ”΄ Branches 20.51% 8/39
πŸ”΄ Functions 3.64% 2/55
πŸ”΄ Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by πŸ§ͺjest coverage report action from 3e6bb3f2000f887b83e3872de6ac732597005478

ofreyssinet-ledger commented 2 years ago

/generate-screenshots

github-actions[bot] commented 2 years ago

Generating new screenshots

LFBarreto commented 2 years ago

Tested on linux + spanish: new users flow :heavy_check_mark: existing users :heavy_check_mark:

localhost_8080_webpack_index html_theme=null appLocale=es localhost_8080_webpack_index html_theme=null appLocale=es_2