LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 297 forks source link

Region settings: translate region names in app's language #4934

Closed ofreyssinet-ledger closed 2 years ago

ofreyssinet-ledger commented 2 years ago

πŸ¦’ Context (issues, jira)

LIVE-1845

πŸ’» Description / Demo (image or video)

Before: each region is translated according to its own locale

https://user-images.githubusercontent.com/91890529/164019159-e9160a5b-56c8-4f86-ab50-675b991e851e.mov

After: each region is translated according to the app's locale

https://user-images.githubusercontent.com/91890529/164019183-745e96d5-d938-4a6b-a51e-dba1d4d79e79.mov

πŸ–€ Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

github-actions[bot] commented 2 years ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements 8.74% 9/103
πŸ”΄ Branches 0% 0/19
πŸ”΄ Functions 2.94% 1/34
πŸ”΄ Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by πŸ§ͺjest coverage report action from f527488e9c3ef886ea5f32bf2e1efbdcc73cd1b8