Closed ofreyssinet-ledger closed 2 years ago
Thanks for your contribution. To be able to merge in develop branch, you need to:
/generate-screenshots
[ ] if needed, /upgrade-llc
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc
to switch back to ledger-live-common@develop here before merging.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π΄ | Statements | 8.74% | 9/103 |
π΄ | Branches | 0% | 0/19 |
π΄ | Functions | 2.94% | 1/34 |
π΄ | Lines | 8.33% | 8/96 |
Report generated by π§ͺjest coverage report action from f527488e9c3ef886ea5f32bf2e1efbdcc73cd1b8
π¦ Context (issues, jira)
LIVE-1845
π» Description / Demo (image or video)
Before: each region is translated according to its own locale
https://user-images.githubusercontent.com/91890529/164019159-e9160a5b-56c8-4f86-ab50-675b991e851e.mov
After: each region is translated according to the app's locale
https://user-images.githubusercontent.com/91890529/164019183-745e96d5-d938-4a6b-a51e-dba1d4d79e79.mov
π€ Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!