lambertkevin commented 2 years ago

🦒 Context (issues, jira)

💻 Description / Demo (image or video)

PR must pass CI, rebase develop if conflicts. Thanks!

on QA: at least one of these two checkboxes must be checked:
- [ ] a specific test planned is defined on Jira
- [ ] this PR is covered by automatic UI test
on delivery: at least one of these two checkboxes must be checked:
- [x] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
- [ ] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

github-actions[bot] commented 2 years ago

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	8.74%	9/103
🔴	Branches	0%	0/19
🔴	Functions	2.94%	1/34
🔴	Lines	8.33%	8/96

Report generated by 🧪jest coverage report action from c951db99c5af8791dd69b0cceb0bd3a3956170ec

ghost commented 2 years ago

@gsoares-ledger adding you as reviewer just in case you have spare time ^^ as you're the only other NFT expert around.

ghost commented 2 years ago

Not for 2.41 branch, pending its merge into develop.