LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
952 stars 301 forks source link

fix/market details screen nav #4945

Open LFBarreto opened 2 years ago

LFBarreto commented 2 years ago

πŸ¦’ Context (issues, jira)

πŸ’» Description / Demo (image or video)

Fixes issue on navigation on market details page. Now data shows up instantly + double breadcrumb fix + removal of forced refresh when coming back to main list page.

https://user-images.githubusercontent.com/11752937/165238987-94d9f682-e2ca-42d7-8761-28495a29f46f.mp4

πŸ–€ Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

github-actions[bot] commented 2 years ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements 23.46% 38/162
πŸ”΄ Branches 20.51% 8/39
πŸ”΄ Functions 3.64% 2/55
πŸ”΄ Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by πŸ§ͺjest coverage report action from 311666242963593bf51d316b9ff85f702dadf1b3

LFBarreto commented 2 years ago

/generate-screenshots

github-actions[bot] commented 2 years ago

Generating new screenshots

juan-cortes commented 2 years ago

CI is not running, does this have a linked Jira task?

ofreyssinet-ledger commented 2 years ago

the branch name should be bugfix/... no?