Remove @ledgerhq/ledger-core again after bad merge - Githubissues

LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)

https://www.ledger.com/live

MIT License

954 stars 298 forks source link

Remove @ledgerhq/ledger-core again after bad merge #4951

Closed ghost closed 2 years ago

ghost commented 2 years ago

🦒 Context (issues, jira)

@ledgerhq/ledger-core was initially removed by https://github.com/LedgerHQ/ledger-live-desktop/pull/4867 but somehow reappeared probably after some bad merge.

💻 Description / Demo (image or video)

This PR just removes it again.

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

on QA: at least one of these two checkboxes must be checked:
- [ ] a specific test planned is defined on Jira
- [ ] this PR is covered by automatic UI test
on delivery: at least one of these two checkboxes must be checked:
- [x] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
- [x] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)