Closed ghost closed 2 years ago
Thanks for your contribution. To be able to merge in develop branch, you need to:
/generate-screenshots
[x] if needed, /upgrade-llc
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc
to switch back to ledger-live-common@develop here before merging.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π΄ | Statements | 23.46% | 38/162 |
π΄ | Branches | 20.51% | 8/39 |
π΄ | Functions | 3.64% | 2/55 |
π΄ | Lines | 24.16% | 36/149 |
Report generated by π§ͺjest coverage report action from 675485dd35131e9407d33a4fc822b79e00f938a0
π¦ Context (issues, jira)
One UI snapshot is broken on develop since that run: https://github.com/LedgerHQ/ledger-live-desktop/actions/runs/2318158256 Introduced with that PR : https://github.com/LedgerHQ/ledger-live-desktop/pull/4973/files
This PR gets it back to normal.
π» Description / Demo (image or video)
π€ Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!