LedgerHQ / ledger-live-desktop

⛔️ DEPRECATED - Ledger Live (Desktop)
https://www.ledger.com/live
MIT License
954 stars 299 forks source link

Support for ERC20 tokens #970

Closed balthazar closed 5 years ago

balthazar commented 6 years ago

Part of the application

ETH portfolio calculations, sending dialog & related APIs.

Description

As a Ledger evangelist, I think the main (and potentially only) missing feature which prevents your user base from completely switching to Ledger Live and ditch current solutions like MEW or MyCrypto is ERC20 support.

I don't believe I'm qualified enough to undertake such a task, but I'm sure @meriadec would be up for it!


And Good job on the release !

ksheni56 commented 6 years ago

Yes, Token support is a strong need. And probably the Ledger Team should try to dive into a partnership with Global Blockchain Technologies and support there new currency Laser "Photons".

Niceday

gre commented 6 years ago

I agree with you about this feature, this is in the Roadmap.

ah2020b commented 6 years ago

Support token erc20 native!

wichtigwicht commented 6 years ago

That's pretty much the only reason I don't use Ledger Live. My portfolio consists mainly of ERC20 tokens. It would be great if the team could dedicate themselves to integrating this function. But I don't just want to complain: The software itself looks great and I'm generally very happy that you exist. Keep up the good work!

ghost commented 6 years ago

Is this actively being worked on?

ah2020b commented 6 years ago

You can use. Just use etherscan to see the erc20 balance

Em qua, 15 de ago de 2018 19:28, Scitoshi Nakayobro < notifications@github.com> escreveu:

Is this actively being worked on?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/ledger-live-desktop/issues/970#issuecomment-413290862, or mute the thread https://github.com/notifications/unsubscribe-auth/AdkFhgOonlN_KEnAyGiunjN7wnxzr7dbks5uRGg2gaJpZM4VIE7P .

ghost commented 6 years ago

@andrehortab2u That's not at all what I asked. I'm asking if support for ERC-20 tokens is being worked on for Ledger Live. Of course I can use etherscan or ethplorer or whatever but that's not even related.

balthazar commented 6 years ago

@sci4me No point answering to someone who obviously doesn't know what he's talking about, just ignore them.

ah2020b commented 6 years ago

You can store erc20 in your ledger, this is a fact.

And to see this erc20 tokens you will need to use etherscan or another web wallet

Em qua, 15 de ago de 2018 21:16, Scitoshi Nakayobro < notifications@github.com> escreveu:

@andrehortab2u https://github.com/andrehortab2u That's not at all what I asked. I'm asking if support for ERC-20 tokens is being worked on for Ledger Live. Of course I can use etherscan or ethplorer or whatever but that's not even related.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/ledger-live-desktop/issues/970#issuecomment-413321791, or mute the thread https://github.com/notifications/unsubscribe-auth/AdkFhlV4S-sqSGWuCWL1hwI4m-rkzx_Aks5uRIGagaJpZM4VIE7P .

balthazar commented 6 years ago

ah2020b commented 6 years ago

Kkkkk

Em qui, 16 de ago de 2018 08:51, Balthazar Gronon notifications@github.com escreveu:

https://camo.githubusercontent.com/2c56a164e7339d2729a7878821a5ec127f21e702/68747470733a2f2f6173736574732d6175746f2e72626c2e6d732f35663064653135386563303130393638343138346266616539343565626163653664356132636436393932333938306632363863613761393162383833306133

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/ledger-live-desktop/issues/970#issuecomment-413457720, or mute the thread https://github.com/notifications/unsubscribe-auth/AdkFhgfRN3cuT_1W0zTASnB1wCdyy6SNks5uRSRjgaJpZM4VIE7P .

ghost commented 6 years ago

@andrehortab2u Again, you're not answering the question. You're completely ignoring it, actually. Be useful or go away lol.

ah2020b commented 6 years ago

You are a competitor that lost the game and think I'm a employe of Ledger Wallet, but you are complete wrong. I'm just a customer that find the best way to keep safe more than 1000 btc, eth, xrp, ltc, ecr20 token... in one device, Ledger Wallet.

Invest in Scrum and P&D so you could try to hit the same level of Ledger Wallet. It's not perfect, but is the best cold wallet that we have in this planet.

Em qui, 16 de ago de 2018 18:16, Scitoshi Nakayobro < notifications@github.com> escreveu:

@andrehortab2u https://github.com/andrehortab2u Again, you're not answering the question. You're completely ignoring it, actually. Be useful or go away lol.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/ledger-live-desktop/issues/970#issuecomment-413619779, or mute the thread https://github.com/notifications/unsubscribe-auth/AdkFhmMkrt8YXo0xelGC0RcdtDAeYcnzks5uRajdgaJpZM4VIE7P .

ghost commented 6 years ago

@andrehortab2u -_-

stevesbrain commented 6 years ago

@andrehortab2u Everybody here actually agrees with you - you can definitely store ERC20 tokens on the Ledger.

However, this feature request is for integrating/displaying ERC20 token balances in the "Ledger Live" software. Basically, people want to see ERC20 tokens as part of the unified interface, rather than having to use MEW etc.

ah2020b commented 6 years ago

Yes sure, so let's wait the team to do this

Em sex, 17 de ago de 2018 00:43, Steve Divskinsy notifications@github.com escreveu:

@andrehortab2u https://github.com/andrehortab2u Everybody here actually agrees with you - you can definitely store ERC20 tokens on the Ledger.

However, this feature request is for integrating/displaying ERC20 token balances in the "Ledger Live" software. Basically, people want to see ERC20 tokens as part of the unified interface, rather than having to use MEW etc.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LedgerHQ/ledger-live-desktop/issues/970#issuecomment-413716454, or mute the thread https://github.com/notifications/unsubscribe-auth/AdkFhsfuYia0d5Z8gpTMU4MkO7pUBM_7ks5uRgOmgaJpZM4VIE7P .

gre commented 6 years ago

Yes, the Nano S does support ERC20 tokens via the Ethereum app (and obviously can already be used in many websites like decentralized exchanges) but it's not integrated and visible on Ledger Live as part of your global portfolio nor you can make ERC20 transactions with Ledger Live yet. It is obvious there are work to be done to support these ERC20 tokens in Ledger Live, it is not so trivial and we already have started to discussed about it internally.

I'm locking the thread because the team need to focus on its implementation first. Please keep such discussion outside of our GitHub.

theoturner commented 5 years ago

As this conversation is now unlocked again, I'd like to voice support for ERC20 management in Ledger Live.

gre commented 5 years ago

yes

fuorissimo commented 5 years ago

One year passed and erc20 native, still not added? o my god!

gre commented 5 years ago

was shipped in develop.

meriadec commented 5 years ago

:rocket: