Regressions due to branching between JavaScript and TypeScript files

[ofreyssinet-ledger]

Fixes:

• Missing setting in debug settings screen (<OpenDebugEnv />). (cf. https://github.com/LedgerHQ/ledger-live-mobile/pull/2172)
• Missing "system" theme parameter in Theme settings.
• Regression on device name displayed in <Scanning /> pair device screen: (cf. https://github.com/LedgerHQ/ledger-live-mobile/pull/2017.)
• Regression in GenericErrorView -> this view should check the bluetooth permission in case the error is an instance of BluetoothRequired. (cf. https://github.com/LedgerHQ/ledger-live-mobile/pull/2131)
• Regression in OperationRow, the NFT name was not being rendered for NFT operations.

More context for this PR:

I made a script in scripts/v3check.js for the purpose of comparing git history between JS files and their TS/TSX counterpart.

Basically it checks the creation date of a tsx file (e.g. filename.ts|tsx) and lists all the commits that happened since that date on the corresponding file (filename.js). It then generates a markdown string with a TODO list, that you can see in the following comment on this PR.

This allows us to detect changes that might have been done on one side in develop and might not have been included in the rebranding files (the typescript ones).

The script is quite rudimentary so it might not catch everything but it caught two of the regressions that we already identified before (regression on the "region setting" feature https://github.com/LedgerHQ/ledger-live-mobile/pull/2332 and regression on some fixes on the discreet mode https://github.com/LedgerHQ/ledger-live-mobile/pull/2365 ).

On top of that as you can see in the following list it helped me to catch some other regressions (Upon checking each commit in the list one by one, I then added for the 🚨 emoji whenever I found a regression) that happened because of the branching between js and ts files.

I'm pushing the script to the repo even though it will probably not be used anymore on LLM, but it might be useful for the pre-release of the LLD rebranding. Eventually we can delete it.

Type

Regression fixes

Context

v3 pre-release

Parts of the app affected / Test plan

[ofreyssinet-ledger]

• [x] src/components/BottomModal.js

  • [x] Wed Feb 16 2022 a050334df098dea844b6191982b6c4d5ea544b86 LIVE-926 Disable closing modals while inline install is happening (#2197)

• [x] src/components/Button.js

  • [x] Mon Mar 21 2022 baf09506b4919e574698827435de743974cce457 LIVE-1468 Prevent useless rerenders on NFT Gallery (#2257)

• [x] src/components/CurrencyRate.js

  • [x] Tue Feb 22 2022 607b0476b055f84dd6c3a69157f8fe91ababb1d7 Merge pull request #2220 from LedgerHQ/bugfix/LIVE-973-discreet-fix

• [x] src/components/DiscreetModeButton.js

  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x

• [x] src/components/GenericErrorView.js

  • [x] Thu Jan 20 2022 a65c01a3399f4e6dad6b458a3952499e3826795b LL-5867 - Prompt user to activate bluetooth (#2131) EDIT: 🚨🚨🚨🚨🚨 REGRESSION CAUGHT HERE 🥳

• [x] src/components/LText/index.js

  • [x] Mon Mar 21 2022 baf09506b4919e574698827435de743974cce457 LIVE-1468 Prevent useless rerenders on NFT Gallery (#2257)

• [x] src/components/OperationRow.js

  • [x] Mon Mar 21 2022 baf09506b4919e574698827435de743974cce457 LIVE-1468 Prevent useless rerenders on NFT Gallery (#2257) EDIT: 🚨🚨🚨🚨🚨 REGRESSION CAUGHT HERE 🥳 -> the NFT name was not being rendered

• [x] src/components/RequiresBLE/BluetoothDisabled.js

  • [x] Thu Jan 20 2022 a65c01a3399f4e6dad6b458a3952499e3826795b LL-5867 - Prompt user to activate bluetooth (#2131)

• [x] src/components/RootNavigator/MainNavigator.js

  • [x] Wed Mar 09 2022 73b74fcf4b772419e91518c302219d75802e7794 LIVE-1533 - Update Firebase environments (prod/staging/dev) (#2250)
  • [x] Mon Mar 07 2022 b6c189f9002f6fae9815f667fad7f91ed9c2fedc Revert "Hide tab bar when keyboard focus (#2269)" (#2271)
  • [x] Fri Mar 04 2022 aeac7045c290bbc74d5b3035307b51c110b3152e Merge pull request #2234 from LedgerHQ/feat/LIVE-826
  • [x] Fri Mar 04 2022 92371d186365552a472fb2a3601683a679a2b543 Hide tab bar when keyboard focus (#2269)
  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x
  • [x] Tue Feb 08 2022 6e9a36bd2a652528aa10806a8772c14a8101e7e4 Merge pull request #2111 from LedgerHQ/LL-MKT
  • [x] Tue Feb 08 2022 02b88ce425bfa07211ab5c0cd338e11792c649c7 Merge pull request #2178 from LedgerHQ/remove-discover-cherry-pick
  • [x] Mon Feb 07 2022 6920dccb410ac432916e5f6ad9e9441f9200a249 Merge pull request #2176 from LedgerHQ/LL-9168
  • [x] Tue Feb 01 2022 ac12953986ce7869349817809bb8d52f1b042d9a LL-8923 Fix Tab navigation after viewing the NFT gallery

• [x] src/components/RootNavigator/ManagerNavigator.js

  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x

• [x] src/components/SelectDevice/BluetoothEmpty.js

  • [x] Mon Mar 14 2022 6eab5b6607eac1eb19367a9e9143c384d22830e6 LIVE-997 New lotties for all devices (#2272) EDIT: this one isn't really a regression as both lotties for light & dark are actually exactly the same (i checked the file diff)

• [x] src/components/SelectDevice/index.js

  • [x] Mon Mar 14 2022 6eab5b6607eac1eb19367a9e9143c384d22830e6 LIVE-997 New lotties for all devices (#2272)
  • [x] Thu Feb 10 2022 e19e01a101b1c62d046a4f99135289e146a4bb92 Merge pull request #2058 from LedgerHQ/LL-5836-ter
  • [x] Thu Jan 20 2022 a65c01a3399f4e6dad6b458a3952499e3826795b LL-5867 - Prompt user to activate bluetooth (#2131)
  • [x] Sat Jan 15 2022 73c47ebbf2d1e11e9ba2e360b31c3cbd287b79bf Merge pull request #1979 from LedgerHQ/LL-7621

• [x] src/components/TabIcon.js

  • [x] Fri Mar 04 2022 aeac7045c290bbc74d5b3035307b51c110b3152e Merge pull request #2234 from LedgerHQ/feat/LIVE-826
  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x

• [x] src/screens/Account/index.js

  • [x] Tue Feb 22 2022 607b0476b055f84dd6c3a69157f8fe91ababb1d7 Merge pull request #2220 from LedgerHQ/bugfix/LIVE-973-discreet-fix

• [x] src/screens/Onboarding/steps/deviceSelection.js

  • [x] Tue Feb 22 2022 9e1a08940db655476c43a4d93f13ad738a7ba441 LIVE-1392 Show NanoSP by default (#2228)
  • [x] Tue Feb 15 2022 8a122f2c64c36e1bb3d4e67c45f06ed06ce14649 LIVE-559 Ledger Nano S Plus support in Device Actions + other assets (#2172)

• [x] src/screens/Onboarding/steps/language.js

  • [x] Wed Jan 19 2022 33ef8ffb8fc6da40d6ea8ae5b7cb4ab7b8c1eb3e LL-7025 LL-7059 Language discoverability (#1926)

• [x] src/screens/Onboarding/steps/welcome.js

  • [x] Wed Jan 19 2022 33ef8ffb8fc6da40d6ea8ae5b7cb4ab7b8c1eb3e LL-7025 LL-7059 Language discoverability (#1926)
  • [x] Tue Oct 26 2021 15ecc3d5fd03158bb771579897cbd58eab50e304 Upgrade to latest React Native (#1953)

• [x] src/screens/PairDevices/Scanning.js

  • [x] Tue Feb 01 2022 898a63fabb488bf842e7d88f28959a7290a4a87c LL-6987 Use localname for ble devices when available (#2017) EDIT: 🚨🚨🚨🚨🚨 REGRESSION CAUGHT HERE 🥳

• [x] src/screens/Portfolio/Header.js

  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x

• [x] src/screens/Settings/Debug/index.js

  • [x] Tue Feb 15 2022 8a122f2c64c36e1bb3d4e67c45f06ed06ce14649 LIVE-559 Ledger Nano S Plus support in Device Actions + other assets (#2172) EDIT: 🚨🚨🚨🚨🚨 REGRESSION CAUGHT HERE 🥳

• [x] src/screens/Settings/General/LanguageRow.js

  • [x] Wed Jan 19 2022 33ef8ffb8fc6da40d6ea8ae5b7cb4ab7b8c1eb3e LL-7025 LL-7059 Language discoverability (#1926)

• [x] src/screens/Settings/General/ThemeSettingsRow.js

  • [x] Tue Mar 01 2022 7c16f53b08701a4ce5332e8d112044ad315b78c7 Merge pull request #2213 from LedgerHQ/releases/2.38.x EDIT: 🚨🚨🚨🚨🚨 REGRESSION CAUGHT HERE 🥳
  • [x] Tue Feb 08 2022 6e9a36bd2a652528aa10806a8772c14a8101e7e4 Merge pull request #2111 from LedgerHQ/LL-MKT

• [x] src/screens/Settings/General/index.js

  • [x] Tue Feb 01 2022 52bcfc97154b78b3cdbca67cd32896f4bc4ee2cd Merge pull request #1941 from LedgerHQ/LL-6732

• [x] src/screens/makeGenericSelectScreen.js

  • [x] Tue Feb 01 2022 52bcfc97154b78b3cdbca67cd32896f4bc4ee2cd Merge pull request #1941 from LedgerHQ/LL-6732