Convert Feature IDs from Firebase in snake_case - Githubissues

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)

https://ledger.com/live

Apache License 2.0

381 stars 116 forks source link

Convert Feature IDs from Firebase in snake_case #2393

Closed thomasrogerlux closed 2 years ago

thomasrogerlux commented 2 years ago

Naming convention in Firebase is snake_case but naming convention in the code-base is camelCase. This makes the conversion seemless for the team.

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

[ ] pass the CI
[ ] if needed, run /generate-screenshots
[ ] have a dev review
[ ] have a QA review
[ ] if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.