Bugfix/live 1316: edit device name only for Nano X

alexandremgo commented 2 years ago

Context

Bug Fix: LIVE-1316 -> but actually only allowing Nano X to update its device name

Draft

The branch release/v3.0.x needs to be merged first to develop

Screenshots

Nano S - no edit name feature

![Screenshot from 2022-04-07 16-49-18](https://user-images.githubusercontent.com/15096913/162236841-4316555e-57bc-4010-b75e-a1deca807041.png)

Nano X - available edit name feature

![Screenshot from 2022-04-07 16-55-12](https://user-images.githubusercontent.com/15096913/162236785-c6f59e58-16f9-4fc4-9d89-71ac2786be3a.png) ![Screenshot from 2022-04-07 16-55-36](https://user-images.githubusercontent.com/15096913/162236805-771c6e5c-ec82-4e1b-b330-1cd91f9f845a.png)

Parts of the app affected / Test plan

On My Ledger (formerly the Manager tab) you should only be able to change the name of your nano if it is a Nano X

juan-cortes commented 2 years ago

Do not merge this until develop has all the changes from the v3 branch. Once that's done, we can change the target to develop again, in the meantime ✔️ for code, waiting for QA. Builds should be triggered by https://github.com/LedgerHQ/ledger-live-build/actions please @alexandremgo link the job once there is one for QA

alexandremgo commented 2 years ago

Understood, thanks !

For QA:

Link to the associated Android APK: here
Link to the associated iOS IPA: here

LedgerHQ / ledger-live-mobile