search

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)
https://ledger.com/live
Apache License 2.0
382 stars 115 forks source link

Terms of use update popup #2442

Closed thomasrogerlux closed 2 years ago

thomasrogerlux commented 2 years ago

LIVE-1914

We wish to notify users properly when the Terms of Use gets updated, directly through Ledger Live. This PR add a new modal in the Portfolio component that will open when the accepted value from the terms context is false and the user isn't in the onboarding. Closing the modal accepts the new terms.

Screenshot from 2022-05-04 16-52-25

Parts of the app affected / Test plan

cgrellard-ledger commented 2 years ago

Do we want to display the close button in the top right corner ? Modal will be blocking user has to click on “Continue” <= from the specs

thomasrogerlux commented 2 years ago

Do we want to display the close button in the top right corner ? Modal will be blocking user has to click on “Continue” <= from the specs

It's removed, I need to update the screenshot in the comment

nparigi-ledger commented 2 years ago

Tested it by putting currentTermsRequired at a far away date. The modal is popping without problem and the link is working. Tested in spanish. The terms of use redirect to the spanish version of terms of use. Tested in russian. As it doesn't seems to exist, it use the english version as fallback.

:heavy_check_mark: