github-actions[bot]
commented
2 years ago Thanks for your contribution. To be able to merge in develop branch, you need to:
- [x] pass the CI
- [ ] if needed, run
/generate-screenshots - [x] have a dev review
- [x] have a QA review
-
[ ] if needed,
/upgrade-llcWhy /generate-screenshots ?
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
Why /upgrade-llc ?
If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run
/upgrade-llcto switch back to ledger-live-common@develop here before merging.
On the Portfolio (in the Carousel) and on the account screen for Ethereum accounts, we have CTAs that lead to the Lido discover apps.
The logic for these CTAs was using deeplinking (opening this URI:
ledgerlive://discover/lido) and the deeplinks handling and redirection logic for discover apps is in part handled by thePlatformCatalogscreen: react-navigation navigates to thePlatformCatalogscreen with the correct params, then that screen has a useEffect to check the validity of the params (it checks that the app manifest exists and is not filtered) and then navigate to thePlatformAppscreen.The issue with that is that on iOS we have removed the
PlatformCatalogcompletely from the navigation logic so this deeplinking logic cannot work. That is why these CTAs have been disabled on iOS.The simple solution then to reenable these is to implement a direct navigation instead of a deeplink logic.
Wallet > "Recommended" section > Lido card
Ethereum account page > "Stake" CTA
Type
Reenabling existing feature
Context
LIVE-2083
Parts of the app affected / Test plan