Closed nparigi-ledger closed 2 years ago
github-actions[bot]
commented
2 years ago Thanks for your contribution. To be groomed for next release, you need to:
/generate-screenshots[ ] have a QA review
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
henri-ly
commented
2 years ago Code LGTM but I just can see one inconsistency is that Stake button is first on desktop, but third on mobile ? Maybe we should see with @cthepot-ledger what he want for LLM ?
ghost
commented
2 years ago Code LGTM but I just can see one inconsistency is that Stake button is first on desktop, but third on mobile ? Maybe we should see with @cthepot-ledger what he want for LLM ?
Hello @henrily-ledger the UI between mobile and desktop should not necessarily look the same, Chris had discussed this with @nparigi-ledger before implementation and did not comment on the order of buttons. Let's keep it as is for this release and reevaluate for the next one 🙏🏻
Add "stake" button to account page actions for TRON, TEZOS, COSMOS and DOT
Partly based on https://github.com/LedgerHQ/ledger-live-desktop/pull/4921
TRON : If there is already frozen TRON, stake button navigate to Vote flow. If not, it go to freeze flow
https://user-images.githubusercontent.com/89014981/165813966-21153152-f4b3-42c5-b97f-9b035c72e25c.mp4
TEZOS :
https://user-images.githubusercontent.com/89014981/165814000-9d471bb1-b911-4b98-be06-28f9b730b828.mp4
COSMOS :
https://user-images.githubusercontent.com/89014981/165814009-12819cb8-036d-43f6-816f-0b148dbbeb0f.mp4
DOT : If there is already bonded DOT, stake button navigate to Nominate flow. If not, it goes to bond flow
https://user-images.githubusercontent.com/89014981/165814015-8fa334f3-19a2-4104-840a-9df2d5bfac53.mp4
Type
Feature
Context
https://ledgerhq.atlassian.net/browse/LIVE-2142
Parts of the app affected / Test plan
Account page -> Tezos, cosmos, dot, tron