Workaround fix for LIVE-2121 - Githubissues

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)

https://ledger.com/live

Apache License 2.0

381 stars 116 forks source link

Workaround fix for LIVE-2121 #2470

Closed gre closed 2 years ago

gre commented 2 years ago

this PR patches a react-native-video bug "on the fly" in a postinstall as a workaround for the real future fix to do for LIVE-2121

[ ] the fix need to be tested. As we should no longer have a crash at boot, it is now not clear what is then the behavior of Ledger Live (does it crash, does it render a white page instead of the video,...)

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

[x] pass the CI
[x] if needed, run /generate-screenshots
[x] have a dev review
[ ] have a QA review
[x] if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.