search

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)
https://ledger.com/live
Apache License 2.0
381 stars 116 forks source link

Feature/rating #2477

Closed cgrellard-ledger closed 2 years ago

cgrellard-ledger commented 2 years ago

Jira : LIVE-1857 Figma : https://www.figma.com/file/CTMrn7rPGH08SPhB7PSiot/LLM-%2F-Rating-app?node-id=2870%3A28734

Need the live-common package to be updated

Type

Context

Parts of the app affected / Test plan

https://user-images.githubusercontent.com/17146928/166492347-d76b9b2e-e1fb-4c90-9005-ff45a2b51e1c.mp4

https://user-images.githubusercontent.com/17146928/166492364-fa4a3858-675e-4c6e-943d-564833d19b33.mp4

ofreyssinet-ledger commented 2 years ago

is it possible to do a rebase on develop and skip the "merge develop into this branch" commit so we have a clean diff & history ?

cgrellard-ledger commented 2 years ago

is it possible to do a rebase on develop and skip the "merge develop into this branch" commit so we have a clean diff & history ?

On it

ofreyssinet-ledger commented 2 years ago

would be cool for a feature like that to write a short description of how it works & what it achieves, that makes the job easier for reviewers I think as they will understand the code and general logic faster